Unit tests #274
Closed
Unit tests #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean-Grimal
previously approved these changes
Aug 11, 2023
|
It seems that many libraries are being redone, including safetransfer. so I would scope this PR to specific libraries that are stable, and create issues to track each library that we plan to test. Perhaps maybe even splitting this PR to one PR for each lib. In fact, I would generally advise that each branching of testing come with its own issue and PR. Big PRs are not ze way IMO, especially for tests that can be cleanly separated from each other since they should not depend on each other (unless the base tests are being worked on) |
MerlinEgalite
dismissed
Jean-Grimal’s stale review
The base branch was changed.
I'll split the PR then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should we also test
SafeTransferLib(which is already extensively tested here) and the WAD based operations fromFixedPointMathLib(which are already extensively tested here)?